There are some situations and edge-cases when N+1 query detection doesn’t work properly. The scope of this task is to explore and fix as many as possible.

2022-11-18 (deployed)

• [x] Bugfix N+1 detection failed when there was a ! in a closure:

collect($request->ids)
  ->filter(fn ($id) => $id)
  ->map(fn (int $id) => Post::find($id)?->id)
  ->reject(fn ($post) => !$post)
  ->toArray();

• [x] Bugfix: N+1 detection failed when there was a return statement before a DB transaction:

// Worked well
public function execute()
{
  DB::transaction(function () {
		// ...
	});
}

// Caused an error:
public function execute()
{
  return DB::transaction(function () {
		// ...
	});
}

• [x] Bugfix: it tried to evaluate a DB::transaction as if it was a collection closure when it was not the first line of a function:

// Worked well
public function execute()
{
  DB::transaction(function () {
		// ...
	});
}

// Caused an error:
public function execute()
{
	$myService = app(MyService::class);
	
  DB::transaction(function () {
		// ...
	});
}

• [x] Bugfix: closures without arguments caused an error:

// Woked well
Post::all()->map(function (Post $post) {
	// ...
});

// Caused an error
$this->withExceptionHandling(function () {
	// ...
});

• [x] Bugfix: if the file didn’t contain a namespace it caused an error:

<?php

function my_str_helper()
{
		// ...
}

• [x] Improvement: Exclude file types that caused problems but do not contain real business-code:
  • [x] Service providers
  • [x] Kernel files
  • [x] Support classes

2022-11-19 (deployed)